feat: ✨ Links to openfeedbacks #24
Merged
+1,365
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taorepoara
requested changes
Jun 3, 2023
There was a problem hiding this comment.
Thanks @gouz for this PR.
You're right, the icons could be bigger and we can give them a look of a button.
For the unit tests, you can check that every session in the camping-data.js file has a openfeedback link.
You also should add the openfeedback link in the session pages.
Co-authored-by: Thomas DA ROCHA <[email protected]>
Co-authored-by: Thomas DA ROCHA <[email protected]>
All done ;) Thanks for the advices |
taorepoara
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Description des modifications
Add links to OpenFeedBack website on each session to allow a vote and give feedbacks to the author.
Liste de contrôle
J'ai inclus des tests unitaires qui couvrent mes modifications
J'ai ajouté/mis à jour la documentation concernant mes modifications
Point technique/remarque
I think we can improve the a11y with bigger icons and a look like buttons